-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refined trait implementations #3245
Merged
Merged
Commits on Mar 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ef84eb4 - Browse repository at this point
Copy the full SHA ef84eb4View commit details
Commits on May 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d035998 - Browse repository at this point
Copy the full SHA d035998View commit details -
Emphasize the possibility of continuing to use `#[refine]` in future editions, and list out all the options under Unresolved Questions. Include the attribute in examples. Simplify the usage of `#[refine]` in existing editions so that it is needed to refine any aspect of an API, instead of new features being refine-able by default and old ones needing the attribute. Move any discussion of *not* doing a soft transition to Unresolved Questions to simplify the Reference Level Explanation a bit.
Configuration menu - View commit details
-
Copy full SHA for 409f3dd - Browse repository at this point
Copy the full SHA 409f3ddView commit details
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 166024a - Browse repository at this point
Copy the full SHA 166024aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cc16b - Browse repository at this point
Copy the full SHA f4cc16bView commit details
Commits on Aug 18, 2022
-
Remove unresolved question about a soft transition
It doesn't seem realistic that we will avoid doing a soft transition at all. Since it was decided that we would definitely adopt #[refine] in the current edition, I don't think this question is relevant anymore.
Configuration menu - View commit details
-
Copy full SHA for f298eda - Browse repository at this point
Copy the full SHA f298edaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5311c59 - Browse repository at this point
Copy the full SHA 5311c59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a97726 - Browse repository at this point
Copy the full SHA 3a97726View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.