Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Generic member access for dyn Error trait objects #2895

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

RFC: Generic member access for dyn Error trait objects #2895

Changes from 26 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
39fc23e
Initial commit for first rfc
yaahc Apr 1, 2020
63d0539
First wave of edits
yaahc Apr 2, 2020
6d9a212
more edits
yaahc Apr 2, 2020
c1fd1f6
more edits
yaahc Apr 2, 2020
f344bd9
maybe time to start showing ppl this
yaahc Apr 2, 2020
9726cfe
simplify summary
yaahc Apr 2, 2020
9dd4113
oops, didnt realize this was a suggested edit
yaahc Apr 2, 2020
49fc1d0
post eliza review
yaahc Apr 2, 2020
f2073ac
Adams comments
yaahc Apr 6, 2020
1fc15e9
rewrite to focus on nika's version
yaahc May 4, 2020
460c523
proof reading
yaahc May 4, 2020
c8b80ed
boop
yaahc May 4, 2020
f16045d
boop
yaahc May 4, 2020
e12ba35
boop
yaahc May 4, 2020
9581f78
boop
yaahc May 4, 2020
6143f6d
boop
yaahc May 4, 2020
1bb8ca7
boop
yaahc May 4, 2020
e82ac82
boop
yaahc May 4, 2020
53431f5
boop
yaahc May 4, 2020
6451b1c
boop
yaahc May 4, 2020
f74f64f
boop
yaahc May 5, 2020
75ef121
fix attribution to be less confusing and mention source
yaahc May 5, 2020
ac0f94e
nikanit
yaahc May 5, 2020
8d55678
Update text/0000-dyn-error-generic-member-access.md
yaahc May 5, 2020
7f87544
rename to provide_context
yaahc May 5, 2020
bcb4823
Update based on kennys changes
yaahc May 5, 2020
2ea013d
Document divergence from object-provider crate
yaahc May 5, 2020
248e4ca
Add example to code snippet
yaahc May 5, 2020
ef2e47e
update to include nikas updates
yaahc May 6, 2020
d055bbb
Update text/0000-dyn-error-generic-member-access.md
yaahc May 7, 2020
ac79814
Apply suggestions from code review
yaahc May 7, 2020
41b589b
reply to adams coments
yaahc May 11, 2020
defeafe
make type_id fn in Request private
yaahc May 11, 2020
48adce6
remove type_id fn
yaahc May 11, 2020
0d441ac
update example to use successors
yaahc Jul 28, 2020
7b98760
add back missing write
yaahc Jul 28, 2020
407ce78
update rfc to include new object provider API
yaahc Dec 4, 2020
84c8bf7
add examples for by value
yaahc Dec 4, 2020
fb02f91
Apply suggestions from code review
yaahc Feb 26, 2021
61be66b
update RFC to be based on dyno design
yaahc Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading