-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links #1942
Update links #1942
Conversation
Old links to prototypes are obsolete, should link to source instead.
Hey thanks! I was actually looking for the MIR representation today from this RFC. Helped me find it :) |
text/1211-mir.md
Outdated
current AST to the HIR is not yet complete, but it can be found in the | ||
[`tcx` module][tcx]. | ||
current AST to the HIR is not yet complete, but it can be found | ||
[here][hair-mod]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In either the text or link there is some confusion between the HIR and the HAIR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the RFC is talking about HAIR and not HIR. I guess the text should reflect that! :) I'll make another change.
Might be a good idea to link to specific revisions instead. (Press y on https://github.com/rust-lang/rust/tree/master/src/librustc/mir to get https://github.com/rust-lang/rust/tree/11bc48a15a7ef23ba795a77d6eb72e4f873373b4/src/librustc/mir.) |
@killercup Didn't know you could do that :) Are you suggesting to use that specific revision? |
@patiences That was just the latest commit when I wrote the comment. If you don't want to change the RFC, you could also use a revision from the time the RFC was written. Edit: Aside from the links stuff, it might be nice to add a "Changes in the Implementation" addendum to the RFC. |
@killercup It would be cool if we could link to the commit from when this was written to preserve the RFC (I'd be interested in seeing MIR at its earliest stages myself!) but I think the code has moved from Niko's repo to the Rust repo since the time of writing. I'm afraid I don't know if the original prototype stuff is still around. I'd love to see such an addendum too, but I'm not qualified to write that... :) @nikomatsakis How's this look to you? :) |
@patiences definitely we should update the links; it seems like linking to master is almost guaranteed to go out-of-date eventually, though, so perhaps we should link to at least the current HEAD revision? sorry for being slow to give feedback. |
Okay, done :) |
@patiences great thanks :) |
Old links to prototypes are obsolete, should link to source instead.