PR: add codes key/legend for debug output in regex-automata #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fixed some of the |
Crypto-Spartan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at debug outputs of DFAs I found myself wondering what some of the symbols meant.
D&Qwere fairly intuitive, but it took me some additional digging to figure out what some of the other symbols meant. I took some inspiration from networking command output and added it to the debug output for the 3 DFA types (onepass, dense, & sparse) as well as the Thompson NFA.Output of a network command:
My proposed change:
You can see the
Codeskey/legend added at the top of the debug output.It's a rather small PR, but I felt that the extra detail may help someone looking at the debug output in the future.