Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add the LoongArch stabilized target features #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Doc: Add the LoongArch stabilized target features #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/attributes/codegen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,27 @@ Feature | Implicitly Enables | Feature Name
`tme` | | FEAT_TME --- Transactional Memory Extension
`vh` | | FEAT_VHE --- Virtualization Host Extensions

#### `loongarch`

r[attributes.codegen.target_feature.loongarch]

This platform requires that `#[target_feature]` is only applied to [`unsafe`
functions][unsafe function].

Further documentation on these features can be found in the [LoongArch Reference
Manual], or elsewhere on [LoongArch GitHub Account].

[LoongArch Reference Manual]: https://github.com/loongson/LoongArch-Documentation
[LoongArch GitHub Account]: https://github.com/loongson
Comment on lines +243 to +244
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation that is more alive than these links? The documentation link looks like it is archived, and I don't know what else I would look at on the GitHub account. Is there a new location where the documentation lives? Is there a way to deep-link to the individual features (like wasm does)?


Feature | Implicitly Enables | Description
------------|---------------------|-------------------
`frecipe` | | FRECIPE --- Reciprocal approximation instrutions
`lasx` | `lsx` | LASX --- 256-bit vector instructions
`lbt` | | LBT --- Binary translation instructions
`lsx` | `d` | LSX --- 128-bit vector instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mentions d as an implicitly enabled feature, but I don't see that as a feature that exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response due to the holidays. It looks like we are not yet able to stabilize the lsx feature, as it implicitly depends on the d feature. rust-lang/rust#135015 (comment)

`lvz` | | LVZ --- Virtualization instructions

#### `riscv32` or `riscv64`

r[attributes.codegen.target_feature.riscv]
Expand Down
Loading