Document if-let guards #1082
Open
Document if-let guards #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
added
the
S-waiting-on-stabilization
ghost
reviewed
Aug 13, 2021
| @@ -102,6 +111,21 @@ let message = match maybe_digit { | |||
| }; | |||
| ``` | |||
|
|
|||
| `if let` guards are introduced by the `if let` keywords and are composed of a pattern, an `=` and a scrutinee expression. | |||
There was a problem hiding this comment.
Suggested change
| `if let` guards are introduced by the `if let` keywords and are composed of a pattern, an `=` and a scrutinee expression. | |
| `if let` guards are composed following [The Rust Reference `if let` keywords syntax](https://doc.rust-lang.org/stable/reference/expressions/if-expr.html#if-let-expressions). |
There was a problem hiding this comment.
@kw-fn, I think the original is correct here, as it is just describing the syntax, and is a style used throughout the reference as a way to anchor the description of what the text is talking about. Also, we do not use external links, or refer to the reference by name within itself.
|
Thanks @LeSeulArtichaut, this looks good to me! It will need to wait for it to be stabilized on nightly, though happy to discuss any feedback from the lang team in the meantime. |
|
This text reads well to me. |
|
I think we can close this with the documentation we have currently in the reference now at time of writing |
8 tasks
| > `if` [_Expression_] | ||
| > | ||
| > _MatchArmIfLetGuard_:\ | ||
| > `if` `let` [_Pattern_] `=` _Scrutinee_<sub>_except lazy boolean operator expression_</sub> |
There was a problem hiding this comment.
Suggested change
| > `if` `let` [_Pattern_] `=` _Scrutinee_<sub>_except lazy boolean operator expression_</sub> | |
| > `if` `let` [_Pattern_] `=` _Scrutinee_ |
After rust#115371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @pnkfelix rust-lang/rfcs#2294 rust-lang/rust#51114