Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Re-implement -Z unpretty=thir-tree #8

Closed
LeSeulArtichaut opened this issue May 19, 2021 · 1 comment · Fixed by rust-lang/rust#86251
Closed

Re-implement -Z unpretty=thir-tree #8

LeSeulArtichaut opened this issue May 19, 2021 · 1 comment · Fixed by rust-lang/rust#86251

Comments

@LeSeulArtichaut
Copy link
Contributor

rust-lang/rust#83842 and rust-lang/rust#85273 are going to break -Z unpretty=thir-tree. Once both land, we need to re-implement them.
@PatchMixolydic PatchMixolydic mentioned this issue May 21, 2021
Closed
@syvb syvb mentioned this issue Jun 12, 2021
Merged
@syvb
Copy link

syvb commented Jul 24, 2021

This will be re-implemented by rust-lang/rust#86251.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 27, 2021
@GuillaumeGomez
Rollup merge of rust-lang#86251 - Smittyvb:thir-tree-again, r=oli-obk
e5aca25 
Support -Z unpretty=thir-tree again

Currently `-Z unpretty=thir-tree` is broken after some THIR refactorings. This re-implements it, making it easier to debug THIR-related issues.

We have to do analyzes before getting the THIR, since trying to create THIR from invalid HIR can ICE. But doing those analyzes requires the THIR to be built and stolen. We work around this by creating a separate query to construct the THIR tree string representation.

Closes rust-lang/project-thir-unsafeck#8, fixes rust-lang#85552.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support -Z unpretty=thir-tree again syvb/rust
2 participants
@syvb @LeSeulArtichaut