Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in initial details #1

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fill in initial details #1

merged 2 commits into from
Sep 21, 2020

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Sep 21, 2020

This fills in our initial group details.

r? @calebzulawski @Lokathor @workingjubilee

CHARTER.md Outdated

The initial implementation will be built on LLVM intrinsics directly rather than `core::arch`.
This is so we don't have to block the portable API on filling in a lot of missing intrinsics in `core::arch` on non-x86 platforms.
Migrating from LLVM intrinsics to `core::arch` is kept as a future possibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would also require some sort of detection of #[target_feature], since LLVM intrinsics already interact with it correctly. Not sure if it's worth noting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I'm aware, you tell LLVM what you want and you tell it the features available and it solves the problem as best it can. Which is what makes intrinsics so powerful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry--I meant that switching to core::arch would probably require a language change as well, to allow that same interaction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Moving to a core::arch based implementation would be a Tall Task, to say the least.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what I was trying to get at with this was consciously not painting ourselves into any corners that would make moving to core::arch totally infeasible instead of just lots of work. It probably goes without saying. Should I reword it or just cut it out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should make it clear it's not exclusively possible with LLVM intrinsics, but I think this is potentially misleading when the language feature is probably a bigger hurdle than expanding core::arch. Not sure the best way of phrasing that, though! For reference, rust-lang/rust#42515 seems to be the associated issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like we’ll want to capture this, but probably not in the charter 🙂 I’ll just remove this note 👍

@KodrAus KodrAus merged commit 4afb8d4 into rust-lang:master Sep 21, 2020
@KodrAus KodrAus deleted the initial branch September 21, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants