-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account some warnings to fix CI #315
Conversation
Looks like CI is less than fully fixed :/ |
Ouch, checking now... |
f031d0e
to
d3c6003
Compare
This bug has been resolved: bugs.llvm.org/show_bug.cgi?id=36982
d3c6003
to
d0d7003
Compare
Failures:
So something goes wrong on AArch64 since CI passed, maybe related to the recent LLVM bumps? I don't see any related commits here. I'd like to file this as an issue and skip tests for now if it's reasonable. @Lokathor Thoughts? |
We've uncovered aarch64 optimization-related LLVM bugs in rust-lang/portable-simd#80 so I would agree: it seems that something in aarch64 codegen is busted (maybe always, maybe only now) and it's likely not our fault. But the thought of shrugging off what appears to be a new behavioral deviation for tier 1 targets makes me itch. I wouldn't find skipping the tests entirely unacceptable, just... wow, the bit rot. |
But on the other hand, this also hinders further tests on CI (https://travis-ci.com/github/rust-lang/packed_simd/builds/220445170). |
Well, this is blocking landing any other maintenance, so might as well I guess. |
Looking at the changes, it's just tests changing right? So the code itself is no worse with this PR, it's only as broken as it might have been before. If we want to merge this we should and then we can continue later once the llvm bug is addressed. |
Okay, CI still has a lot of failures but at least we pass all the non-allow-failure jobs. I'm going to fix some of them but meanwhile, we can merge this to unblock other PRs? |
Fixes #5