Ignore a doctest that will be broken by a stabilization #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it seems nomicon doctests are run in CI but aren't blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at rust-lang/rust#122792, I'm proposing to stabilize a feature that will allow
let Ok(x) = result;to compile forresult: Result<T, Void>. Problem is, the nomicon contains a doctest that asserts that this doesn't compile. Which breaks CI on my stabilization PR 😁.I don't know if there's a standard procedure for this, so I thought I'd ignore the test here first, wait for submodule update on the rustc side, which will allow my PR to pass CI. If it gets merged we can re-enable the doctest and update it. If the stabilization doesn't go through we can just revert this. Is that sensible?