Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write name and value for each env var #925

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Write name and value for each env var #925

merged 2 commits into from
Aug 27, 2019

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Aug 26, 2019 •
edited
Loading

In order to res0lve #756 is necessary to have the whole "NAME=VALUE" sequence of bytes written into memory instead of just the value.

This change does not affect the interface of the shim::envs::EnvVars type in any way.

r? @RalfJung @oli-obk

@RalfJung
Copy link
Member

Could you add a doc comment to EnvVars explaining the invariant you introduced here? That the pointer stored in the map points to a null-terminated C string starting with name=?

@RalfJung
Copy link
Member

Looking good, thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

📌 Commit 7d93cc7 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Aug 27, 2019

⌛ Testing commit 7d93cc7 with merge 283928a...

bors added a commit that referenced this pull request Aug 27, 2019
@bors
Auto merge of #925 - christianpoveda:environ-shim, r=RalfJung
283928a 
Write name and value for each env var

In order to res0lve #756 is necessary to have the whole `"NAME=VALUE"` sequence of bytes written into memory instead of just the value.

This change does not affect the interface of the `shim::envs::EnvVars` type in any way.

r? @RalfJung @oli-obk
@bors
Copy link
Collaborator

bors commented Aug 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 283928a to master...

@bors bors merged commit 7d93cc7 into rust-lang:master Aug 27, 2019
@pvdrz pvdrz deleted the environ-shim branch August 27, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdrz @RalfJung @bors