-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for the new type_name
intrinsic.
#761
Conversation
type_name
.type_name
.
I'd prefer to wait for rust-lang/rust#61399 to get merged and then remove the impl here |
Okay. @ecstatic-morse could you reduce this PR to just the test case, and remove the intrinsic implementation? We can then merge that once the Rust PR lands. |
type_name
.type_name
intrinsic.
@RalfJung Done! |
Could you also remove the implementation of the intrinsic from And please rebase onto current master. |
Oh actually never mind, rust-lang/rust#61498 did not land yet. |
Tests are failing though:
|
They will keep failing without a bump of the rustc version we're using in CI |
type_name
intrinsic.type_name
intrinsic.
I'll retrigger a CI run when rust-lang/rust#61498 lands. |
You'll also have to update the |
I updated |
We bump `rust-version` to pick up the new impl from rust-lang/rust#61498 and add a test.
Addresses this comment from @RalfJung.This makes thetype_name
intrinsic calllibrustc_mir::interpret::type_name
instead ofTy::to_string
.I used the implementation ofeval_const_to_op
as a reference.This now adds a test for the
type_name
intrinsic and removes the miri impl in favor of the in-core one.