Retagging: Recurse into compound values #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Nov 16, 2018
oli-obk
reviewed
Nov 16, 2018
bjorn3
suggested changes
Nov 17, 2018
oli-obk
reviewed
Nov 17, 2018
| } | ||
| _ => {}, // nothing to do | ||
| } | ||
| let mutbl = match place.layout.ty.sty { |
There was a problem hiding this comment.
I think this can be simplified to an if let on builtin_deref(false)
There was a problem hiding this comment.
Unfortunately that reports immutable for Box, making it useless.
There was a problem hiding this comment.
I added a comment explaining this.
There was a problem hiding this comment.
Wat. I need to review all uses of that method now -.-
There was a problem hiding this comment.
Please do.^^ And/or fix that method? ;)
There was a problem hiding this comment.
I guess this is related to the fact that
fn foo(x: &mut i32) { *x = 3 }
works but
fn foo(x: Box<i32>) { *x = 3 }
says it needs a mut, as in mut x: Box<i32>.
oli-obk
reviewed
Nov 17, 2018
oli-obk
approved these changes
Nov 17, 2018
|
Bumped Rust version and merged #523, this should work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches rust-lang/rust#55916, waiting for that to land.