implement floats by running the ops on the host architecture #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,7 +179,15 @@ impl<'a, 'tcx> EvalContext<'a, 'tcx> { | |||
| }} | |||
| } | |||
| match *const_val { | |||
| Float(_f) => unimplemented!(), | |||
| Float(ConstFloat::F32(f)) => { | |||
| let i = unsafe { transmute::<_, u32>(f) }; | |||
There was a problem hiding this comment.
In the spirit of paranoia, I'd rather avoid adding transmutes and instead use the byteorder crate's {read,write}_f{32,64} methods (with matching methods on Memory, I suppose).
erickt
pushed a commit
to erickt/miri
that referenced
this pull request
Feb 4, 2022
Fix serde deserialization for custom hashers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't possibly hope to emulate all target architectures' float quirks. Let's just assert that anyone depending on the minuscule differences between architectures deserves their code to be broken when run through miri.
Instead of running on the host architecture, we can also use one of the following crates for deterministic behaviour not depending on the host architecture
Only
accuratewill emulate the computation closely. The other two are much more precise and will thus differ from running the code on the target.fixes #35