Illumos: Added epoll and eventfd #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-author
RalfJung
reviewed
Jan 13, 2025
tests/pass-dep/libc/libc-eventfd.rs
Outdated
| let fd = unsafe { libc::syscall(libc::SYS_eventfd2, initval, flags) }; | ||
| assert_ne!(fd, -1); | ||
| cfg_if::cfg_if! { | ||
| if #[cfg(target_os = "illumos")] { |
There was a problem hiding this comment.
Please add the #[cfg] to the function instead.
|
Good catch! |
YohDeadfall
force-pushed
the
illumos-epoll-eventfd
branch
from
9016eba to
26ffab4
Compare
RalfJung
reviewed
Jan 13, 2025
RalfJung
reviewed
Jan 13, 2025
| @@ -1,7 +1,7 @@ | |||
| //@compile-flags: -Zmiri-preemption-rate=0 | |||
| //~^ERROR: deadlocked | |||
| //~^^ERROR: deadlocked | |||
| //@only-target: linux | |||
| //@only-target: linux illumos | |||
There was a problem hiding this comment.
Shouldn't this include android as well?
There was a problem hiding this comment.
Yeah, it should.
RalfJung
reviewed
Jan 13, 2025
YohDeadfall
force-pushed
the
illumos-epoll-eventfd
branch
from
4ed3319 to
b6523c0
Compare
|
When updating a PR, please either do a force push or add a new commit. (Generally new commits are preferred, but for small changes to an almost-done PR like this, a force push is okay.) If you first add a new commit and the force-push that away, Github makes it entirely impossible for me to see the diff since my last review. That's clearly a sign of Github being a terrible tool for PR review, but we have to live with the tools we have and work around their limitations... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4017.