Fill out windows io error mapping table #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
Please add a comment in the code documenting this choice. |
|
@sivadeilra - here's one of the PRs related to adding Miri support for Windows FS APIs, RE: #3482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch more of the Windows error codes to the error mapping list. This is all the error codes currently recognized by std IO decoding (https://github.com/rust-lang/rust/blob/75703c1a78c3cd99fa1347b237f3966fb8860e98/library/std/src/sys/pal/windows/mod.rs#L74). When multiple errors map to the same io value, I chose to prefer-non WSA and the most generic sounding variant for the backwards mapping.