Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some SSE/SSE2 intrinsics that are no longer used by stdarch #3747

Merged
merged 1 commit into from
Aug 7, 2024
Merged

remove some SSE/SSE2 intrinsics that are no longer used by stdarch #3747

merged 1 commit into from
Aug 7, 2024

Conversation

RalfJung
Copy link
Member

Fixes #3691

@RalfJung
Copy link
Member Author

Blocked on rust-lang/stdarch#1584 propagating to the rustc repo.

@RalfJung RalfJung added the S-blocked Status: blocked on something happening somewhere else label Jul 13, 2024
@TDecking
Copy link
Contributor

The stdarch patch will also ensure that the "sqrt.ps.256" case in https://github.com/rust-lang/miri/blob/master/src/shims/x86/avx.rs#L78 will never be reached. This case is still present here.

@RalfJung
Copy link
Member Author

Yeah, but sqrt is implemented together with two other functions there so there's not really any code saved by removing that... 🤷

The same goes for sse.sqrt.ss, sse.sqrt.ps.

@RalfJung
Copy link
Member Author

Hm I guess this removes all uses of FloatUnaryOp::Sqrt. So maybe it's worth it after all.

@TDecking
Copy link
Contributor

TDecking commented Aug 6, 2024

@RalfJung rust-lang/rust#128466 got merged. This PR is no longer blocked.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2024

Ah, good point, thanks! :)

@bors r+

@bors
Copy link
Contributor

bors commented Aug 7, 2024

📌 Commit 8bf6dae has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Aug 7, 2024
@bors
Auto merge of #3747 - RalfJung:sse-cleanup, r=RalfJung
0537b14 
remove some SSE/SSE2 intrinsics that are no longer used by stdarch

Fixes #3691
@bors
Copy link
Contributor

bors commented Aug 7, 2024

⌛ Testing commit 8bf6dae with merge 0537b14...

@bors
Copy link
Contributor

bors commented Aug 7, 2024

💔 Test failed - checks-actions

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2024

Ah, maybe we need the rustup to land first.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2024

Hm, no... we had a rustup yesterday, so rust-lang/rust#128466 should have been picked up.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2024

D'oh, this is from a Miri test directly importing the intrinsic.^^

@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 7, 2024

📌 Commit 3e79bb4 has been approved by RalfJung

It is now in the queue for this repository.

@RalfJung RalfJung removed the S-blocked Status: blocked on something happening somewhere else label Aug 7, 2024
@bors
Copy link
Contributor

bors commented Aug 7, 2024

⌛ Testing commit 3e79bb4 with merge 2ae377f...

@bors
Copy link
Contributor

bors commented Aug 7, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 2ae377f to master...

@bors bors merged commit 2ae377f into rust-lang:master Aug 7, 2024
8 checks passed
@RalfJung RalfJung deleted the sse-cleanup branch August 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dead Intel intrinsics
3 participants
@RalfJung @TDecking @bors