Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly implement native exception raise methods in miri #3319

Merged
merged 2 commits into from
May 19, 2024
Merged

Directly implement native exception raise methods in miri #3319

merged 2 commits into from
May 19, 2024

Commits on May 19, 2024

  1. Directly implement native exception raise methods in miri 

    Windows still needs the old custom ABI as SEH unwinding isn't supported
by miri. Unlike DWARF unwinding it preserves all stack frames until
right after the do_catch function has executed. Because of this
panic_unwind stack allocates the exception object. Miri can't currently
model unwinding without destroying stack frames and as such will report
a use-after-free of the exception object.
    @bjorn3 @RalfJung
    bjorn3 authored and RalfJung committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7d74ebe View commit details
    Browse the repository at this point in the history

  2. various small nits 

    - share implementation with miri_starting_unwind
- make test use a custom unwinding class
- extend comments
- use NeedsUnwind more consistently
    @RalfJung
    RalfJung committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c7debbd View commit details
    Browse the repository at this point in the history