Use windows-sys in windows tests
#3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Dec 26, 2023
RalfJung
reviewed
Dec 26, 2023
| /// threads should be able to reacquire the lock while it is locked by multiple other threads in shared mode | ||
| fn all_shared() { | ||
| println!("all_shared"); | ||
|
|
||
| let mut lock = null_mut(); | ||
| let mut condvar = null_mut(); | ||
| let mut lock = MaybeUninit::zeroed(); |
There was a problem hiding this comment.
I think it'd be better to indicate the type of what we are allocating here. Type inference is great but it also makes this code pretty hard to follow if one dos not know the Windows API types by heart.
This applies everywhere in this PR.
RalfJung
reviewed
Dec 26, 2023
test_dependencies/Cargo.lock
Outdated
| @@ -84,9 +84,9 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "getrandom" | |||
| version = "0.2.10" | |||
| version = "0.2.11" | |||
There was a problem hiding this comment.
Please avoid unrelated lockfile changes.
|
Looks good, thanks :) |
bors
added a commit
that referenced
this pull request
Dec 30, 2023
Use `windows-sys` in windows tests This PR adds `windows-sys` to `test_dependencies` so that we don't have to write out windows api bindings for each test.
|
💔 Test failed - checks-actions |
|
looks like macos being macos... |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
windows-systotest_dependenciesso that we don't have to write out windows api bindings for each test.