Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Oct 27, 2022
RalfJung
reviewed
Oct 27, 2022
|
@bors r+ |
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
I was wondering why we hadn't noticed this earlier... turns out there is no doctest and no libcore unit test for this function, so it is not hit by miri-test-libstd. Probably just some ui tests? AFAIK we're trying to avoid using ui tests for things where unit tests could be used. |
|
fyi: I've filled a PR to add doc tests to the |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2022
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Nov 5, 2022
update Miri Noteworthy PRs: - rust-lang#2624 - rust-lang#2626 - rust-lang#2630 - rust-lang#2631
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 20, 2024
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
update Miri Noteworthy PRs: - rust-lang/miri#2624 - rust-lang/miri#2626 - rust-lang/miri#2630 - rust-lang/miri#2631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promised I'll implement it, but then forgot 😅