Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-cargo-miri only about cargo #2408

Merged
merged 3 commits into from
Jul 21, 2022
Merged

make test-cargo-miri only about cargo #2408

merged 3 commits into from
Jul 21, 2022

Conversation

RalfJung
Copy link
Member

Move the things that actually test dependency behavior into the regular test suite, now that we can do that. :)

remove rand (large dependency) and page-size (testing the dependency, not cargo-miri).
keep only byteorder as a "demo" dependency, it is a leaf and builds quickly.
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2022

could also move the tokio fail test to a subfolder at the same time

@RalfJung
Copy link
Member Author

Hm that test is somewhat odd, we wouldn't usually have any fail tests for other crates I think.

and move crate tests to their own folders
@RalfJung RalfJung force-pushed the deps branch 3 times, most recently from 929712c to b1b368c Compare July 21, 2022 13:43
@oli-obk
Copy link
Contributor

oli-obk commented Jul 21, 2022

oh... that makes sense ^^

lgtm modulo that mac failure in CI

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 21, 2022

📌 Commit 4e63975 has been approved by oli-obk

It is now in the queue for this repository.

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 21, 2022

📌 Commit 5e4b646 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 21, 2022

⌛ Testing commit 5e4b646 with merge 46d309f...

@bors
Copy link
Contributor

bors commented Jul 21, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 46d309f to master...

@bors bors merged commit 46d309f into rust-lang:master Jul 21, 2022
@RalfJung RalfJung deleted the deps branch July 21, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants