-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report an error if a #[no_mangle]
/#[export_name = ...]
function has the same symbol name as a built-in shim
#1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_calls/exported_symbol.rs`
…e same symbol name as built-in shims
ghost
commented
Jun 11, 2021
RalfJung
reviewed
Jun 11, 2021
RalfJung
reviewed
Jun 11, 2021
RalfJung
reviewed
Jun 13, 2021
RalfJung
reviewed
Jun 14, 2021
RalfJung
reviewed
Jun 14, 2021
…ng `let link_name = link_name_sym.as_str()`
Looks great, thanks. :) |
📌 Commit aaaa142 has been approved by |
☀️ Test successful - checks-actions |
ghost
deleted the
1776-follow-up
branch
June 15, 2021 10:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1776 (comment).
The error looks like this:
This does not implement "better error messages than we do currently for arg/ABI mismatches" in #1776 (comment) -- I failed to remove all
check_arg_count()
andcheck_abi()
(they are still used insrc/shims/intrinsics.rs
andcall_dlsym()
) and they don't receive the name of the shim.