Update panic machinery to match #[track_caller] changes. #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right, thanks a lot. :) |
This gets miri's tests passing again with rust-lang/rust#67137.
anp
force-pushed
the
track-caller-update
branch
from
38ebe42 to
0a3f460
Compare
|
Rebased now that rust-lang/rust#67137 has landed. Anything else I need to do to unbreak miri? |
|
@anp you need to import |
|
Thanks! Cherry-picked your commit, hopefully CI is happy. |
|
Ugh, I didn't test on travis, this should make check suite green: JohnTitor@7edf4f4 |
|
Awesome. :) @bors r+ |
|
📌 Commit 3607daf has been approved by |
bors
added a commit
that referenced
this pull request
Jan 6, 2020
Update panic machinery to match #[track_caller] changes. This gets miri's tests passing again with rust-lang/rust#67137, I don't think it will pass CI until that has merged.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets miri's tests passing again with rust-lang/rust#67137, I don't think it will pass CI until that has merged.