New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI checks do not accept Option-"like" types #3983

Closed

RalfJung opened this issue Oct 21, 2024 · 1 comment · Fixed by rust-lang/rust#132057

Member

RalfJung commented Oct 21, 2024

Recently we ratified the Option null-pointer guarantee to also apply to Option-like types. Miri should be adjusted to match that.

The text was updated successfully, but these errors were encountered:

RalfJung mentioned this issue

miri: update ABI compat checks to accept Option-like types rust-lang/rust#132057

Merged

joboet added a commit to joboet/rust that referenced this issue


          Rollup merge of rust-lang#132057 - RalfJung:miri-abi-compat, r=wesley…

6b5a58c

…wiser

miri: update ABI compat checks to accept Option-like types

This implements the t-lang decision described [here](rust-lang#130628 (comment)).

Fixes rust-lang/miri#3983

rust-timer added a commit to rust-lang-ci/rust that referenced this issue


          Unrolled build for rust-lang#132057

d95060a

Rollup merge of rust-lang#132057 - RalfJung:miri-abi-compat, r=wesleywiser

miri: update ABI compat checks to accept Option-like types

This implements the t-lang decision described [here](rust-lang#130628 (comment)).

Fixes rust-lang/miri#3983

Member Author

RalfJung commented Nov 7, 2024

Fixed by rust-lang/rust#132057

RalfJung closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment