Cofigurate out ohos target's dependecies to avoid compilation crashes
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wesleywiser Is it convenient to review the PR? |
|
Do these targets support perf counters? It looks like they're Linux systems and there's at least one x86_64 variant, but maybe we can just cfg out the dependency on this platform for now? That would unblock landing this without needing to consider a change in dependencies. |
|
@Mark-Simulacrum thanks for review :)
yes supported.
ok, it's also make sense. |
LuuuXXX
changed the title
ohos target's dependecies to avoid compilation crashes
LuuuXXX
force-pushed
the
update-perf-event
branch
from
7aca6d6 to
2694c03
Compare
Mark-Simulacrum
approved these changes
Dec 22, 2024
|
Will there be a new version released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build ohos rustc targets. but blocked. It seems that
perf-event-open-syssupport is not good(#237 (comment)).The new
perf-event-open-sys2supports this which is an actively maintained fork.cc #237