Update to pulldown-cmark 0.5. #898
Conversation
ehuss
commented
Apr 22, 2019
•
ehuss
commented
- Update to 0.5.2.
- Remove pulldown-cmark-to-cmark and de-emphasis test, incompatible with 0.5.
|
This includes a temporary hack to deal with pulldown-cmark-to-cmark needing to be updated (see Byron/pulldown-cmark-to-cmark#2). Can either wait for that PR to be merged, or remove the example altogether, or leave the hack. This causes some changes in rendering in various rust-lang books since pulldown-cmark better conforms to the markdown spec. If this is merged, there will need to be some coordination in updating the books to fix some bugs. I can handle that, just a heads up. Not sure if this warrants bumping to 0.3 (I don't think so). |
|
Thanks. i'd prefer to wait for that PR to be merged. |
ehuss
force-pushed
the
update-pulldown-cmark
branch
from
212f994 to
1e31017
Compare
ehuss
changed the title
ehuss
force-pushed
the
update-pulldown-cmark
branch
2 times, most recently
from
98dbc8f to
1e31017
Compare
|
I have updated this to 0.5 and removed the pulldown-cmark-to-cmark dependency. I think the no-op example is sufficient to demonstrate how to make a preprocessor. The de-emphasis one didn't work by itself, anyways. I did make a demo using comrak instead (ehuss@98dbc8f if you're curious), which works better than the original. But I think the additional dependencies are too heavy, and it seems to be getting a little convoluted for a simple demonstration. |
|
@ehuss can you resolve the conflicts on this? |
ehuss
force-pushed
the
update-pulldown-cmark
branch
from
f76d298 to
513c35a
Compare
|
@ehuss You have conflict to solve. |
ehuss
force-pushed
the
update-pulldown-cmark
branch
from
513c35a to
3435448
Compare
|
Updated! |
|
I think you need a rebase and update pulldown-cmark to 0.5.2 . |
Since it is not compatible with the new pulldown-cmark. This example isn't directly usable, anyways, and I think the no-op example sufficiently shows how to make a preprocessor.
ehuss
force-pushed
the
update-pulldown-cmark
branch
from
3435448 to
87a411b
Compare
|
Thanks @lzutao. I wish github would notify automatically like bors does. |
* Update to pulldown-cmark 0.4.1. * Update to pulldown-cmark 0.5.2. * Remove pulldown-cmark-to-cmark dependency. Since it is not compatible with the new pulldown-cmark. This example isn't directly usable, anyways, and I think the no-op example sufficiently shows how to make a preprocessor. * cargo fmt * Fix example link.
