fix(theme): Use aria-label alongside title #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested this on macOS with VoiceOver, and it does not pick up the title as the text of the button. Kind of makes sense, since title and aria-label are not the same. This will make sure that the buttons and links are labeled properly.
sorin-davidoi
changed the title
Michael-F-Bryan
approved these changes
Jan 25, 2018
| @@ -172,7 +172,7 @@ function playpen_text(playpen) { | |||
|
|
|||
| var buttons = document.createElement('div'); | |||
| buttons.className = 'buttons'; | |||
| buttons.innerHTML = "<i class=\"fa fa-expand\" title=\"Show hidden lines\"></i>"; | |||
| buttons.innerHTML = "<button class=\"fa fa-expand\" title=\"Show hidden lines\" aria-label=\"Show hidden lines\"></button>"; | |||
There was a problem hiding this comment.
Doesn't using a proper <button> here instead of an <i> mean it becomes something clickable with the usual 3D depression effect?
There was a problem hiding this comment.
No, it looks the same but it becomes focusable. The other buttons were changed in the remove jQuery pull request, but I've somehow missed this one.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Tested this on macOS with VoiceOver, and it does not pick up the title as the text of the button. Kind of makes sense, since title and aria-label are not the same. This will make sure that the buttons and links are labeled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this on macOS with VoiceOver, and it does not pick up the title as the text of the button. Kind of makes sense, since
titleandaria-labelare not the same. This will make sure that the buttons and links are labeled properly.