Skip to content

Conversation

wendajiang
Copy link
Contributor

No description provided.

@wendajiang wendajiang mentioned this pull request Sep 20, 2022
@ehuss
Copy link
Contributor

ehuss commented Sep 21, 2022

Thanks! This seems to have several other changes, so it's not quite clear to me:

  • Updates assert_cmd. Is there a reason this is updated at the same time?
  • It looks like all dependencies have been updated in Cargo.lock?
  • It looks like the msrv documentation hasn't been updated.

@wendajiang
Copy link
Contributor Author

Thanks! This seems to have several other changes, so it's not quite clear to me:

  • Updates assert_cmd. Is there a reason this is updated at the same time?
  • It looks like all dependencies have been updated in Cargo.lock?
  • It looks like the msrv documentation hasn't been updated.

assert_cmd is out-of-habit use the newest version. And the dependencies is from this #1844 and both I revert the dependencies update.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit 75857fb into rust-lang:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants