Fix in order to enable the cmse_nonsecure_entry attribute securely in Rust #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
security boundary It was never supported and that part was accidentally omitted when upstreaming D76518. Differential Revision: https://reviews.llvm.org/D86478 Change-Id: If6ba9506eb0431c87a1d42a38aa60e47ce263039
|
LGTM, thanks! |
vext01
added a commit
to vext01/llvm-project
that referenced
this pull request
Jul 20, 2023
76: Update CI to Debian bookworm. r=ptersilie a=vext01 Co-authored-by: Edd Barrett <vext01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Following the process described here to add an upstreamed bug fix in Rust's fork.
The PR enabling the
cmse_nonsecure_entryin Rust is open here.The specific comment that started the need of this bug fix is here.
Without this bug fix, the
cmse_nonsecure_entryattribute will be a source of security problems (seg faults, information disclosure) if a function with more than 4u32arguments is decorated with it.Original review in LLVM.