Skip to content

Backport #144229 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025
Merged

Conversation

Patryk27
Copy link

Follow-up to #184 - didn't realize that a newly-introduced test there uses an AVR MCU that's been introduced in yet another commit. I've also considered backporting the test to use another MCU, one that's already available, but that would require adjusting the test's assembly output, leaving cherry-picking the MCUs as the easier way out.

Thanks to @dianqk.

1. Added the missing XMEGA2 definition. The avr64 devices use xmega2 which has SPM(X) defined.

2. The avr16/avr32 devices do have SPM and SPMX features, but the current xmega3 definition has not.
   Xmega3 is also used for modern attiny series which do not have SPM(X), so that is correct.
   Leave the avr16/avr32 devices unchanged (using xmega3 to be in sync with gcc definitions).

Fixes llvm#116116
@dianqk dianqk merged commit 99a9d52 into rust-lang:rustc/20.1-2025-02-13 Jul 13, 2025
@dianqk
Copy link
Member

dianqk commented Jul 13, 2025

Updated to Rust: rust-lang/rust#143873.

@Patryk27 Patryk27 deleted the backport-144229 branch July 13, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants