Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump patch for crate #166

Closed
ognevny opened this issue Jan 7, 2024 · 5 comments · Fixed by #168
Closed

bump patch for crate #166

ognevny opened this issue Jan 7, 2024 · 5 comments · Fixed by #168
Labels
dependencies Pull requests that update a dependency file help wanted

Comments

@ognevny
Copy link
Contributor

ognevny commented Jan 7, 2024

just a suggestion, as in msys2 we want to have fix for *-gnullvm target applied at stable so we can update it for needed packages (e.g. starship)

@Byron Byron added help wanted dependencies Pull requests that update a dependency file labels Jan 7, 2024
@Byron
Copy link
Member

Byron commented Jan 7, 2024

Is this something you have experience with and can attempt? Maybe it's as easy as updating a submodule. Even if not, maybe it's an experience worth having as I am typically relying on update-contributions for this and am happy to get these released as often as they happen.

@ognevny
Copy link
Contributor Author

ognevny commented Jan 7, 2024

we need an update to have an ability to compile the crate for aarch64-pc-windows-gnullvm target (MSYS2). an old version included arm64_neon.h which is MSVC only. so there was a build failure

edit: you meant update it myself? I suppose it's better to have final decisions on maintainers' side
edit2: I can contribute if needed only tomorrow

@Byron
Copy link
Member

Byron commented Jan 7, 2024

I can contribute if needed only tomorrow

Yes, please feel free to contribute the update. Unless I am missing something, I'd expect it to pass CI without hitches, and thus is eligible for a release.

@mati865
Copy link

mati865 commented Jan 7, 2024

The update has already happened in #162
It's just not published as a new version and that would be the only necessary action.

@Byron
Copy link
Member

Byron commented Jan 7, 2024

Even better! Then it would be best if someone could create a PR with the version change so I can merge it and create a new release. If I would create that PR I can't review it myself which has the potential for delays.

@ognevny ognevny mentioned this issue Jan 8, 2024
ognevny added a commit to ognevny/libz-sys that referenced this issue Jan 8, 2024
so rust-lang#162 will be applied
fixes rust-lang#166
@ognevny ognevny mentioned this issue Jan 8, 2024
@Byron Byron closed this as completed in #168 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants