-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Build musl for tests #300
Open
tgross35
wants to merge
13
commits into
rust-lang:master
Choose a base branch
from
tgross35:test-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,835
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
test-refactoring
branch
6 times, most recently
from
October 7, 2024 05:24
ac1f7c9
to
fc28dfb
Compare
Add a way to run musl symbols Mostly building Musl works Check for undef symbols Update Fix error with using relinked archives More strict archive checks Clean up warnings More tests Disable more warnings Update build Update build Update build Update syms Update syms More tests passing More tests Make libm-test a default crate Remove unneeded files Download musl in ci Fix unresolved symbols Don't fail fast UNDO let cc link to get cmd output panic with linker Set linker ld env ld env ld env Update More prefixes allowed Add another ppc symbol better test generation Multiple dispatch working Update macros Add many more tests Add sin Try to test more targets Update ci Update build scripts UPdate build printenv in ci Update ci Update ci Update ci Update ci Update ci Update ci Update ci Update ci Update ci Update ci try to fix windows defs Redefine missing symbolsg msvc flags Try inf redefine Disable on msvc change aliases change aliases x86 symbols Weak symbols on macos Weak symbols on macos work! Refactor traits Clean up tuplecall More calls! frexp More calls More calls Update tests. all passing! Update tests
tgross35
force-pushed
the
test-refactoring
branch
from
October 7, 2024 05:24
fc28dfb
to
9df91b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently test on any non-linux targets because results always require running against the
linux-musl
target. Also, the current tests don't allow for non-exact comparisons, which would be problematic if we start using implementations with correct rounding.So: build musl's math functions (can't build the whole library on non-linux systems, but the math functions work) but rename the symbols so we can call them without possibly getting the system libraries.
More experimentation to be done here.