Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite on FreeBSD 11 #948

Closed
wants to merge 1 commit into from
Closed

Conversation

wezm
Copy link
Member

@wezm wezm commented Mar 12, 2018

This PR addresses failures in the test suite on FreeBSD amd64 11.1-RELEASE-p6:

With these changes all test pass.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@wezm
Copy link
Member Author

wezm commented Mar 12, 2018

So CI failed due to it running FreeBSD 10 and not having some of the constants I added (RLIMIT_KQUEUES, RLIMIT_UMTXP). This appears to be an issue in #799 (comment) as well. I can look into generating an updated qemu image if that's the right way to go about it.

@alexcrichton
Copy link
Member

Thanks! Looks like CI may be failing though?

@wezm
Copy link
Member Author

wezm commented Mar 12, 2018

@alexcrichton yep see previous comment. Let me know the best way to proceed.

@alexcrichton
Copy link
Member

Ah sorry was a bit too tired! I'd be fine either recreating the image yeah! If you need help with that I think the old steps are documented in the readme in the ci dir, but I can try to help out otherwise.

If that fails though then we can also whitelist the conflicting constants to not be checked.

@wezm wezm mentioned this pull request Mar 15, 2018
@wezm
Copy link
Member Author

wezm commented Mar 16, 2018

Merged into #950

@wezm wezm closed this Mar 16, 2018
bors added a commit that referenced this pull request Mar 16, 2018
Update the FreeBSD CI image

As per #948 and #799 the FreeBSD CI qemu image needs to be updated to FreeBSD 11. I have done this and updated the README with the detailed steps taken. The new image is available for download at: http://bsd-ci.com/FreeBSD-11.1-RELEASE-amd64.qcow2.xz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants