Link against kevent@FBSD_1.0 to fix ABI compat with FreeBSD12. #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct kevent was modified in FreeBSD12. The @FBSD_1.0 symbol supports the old structure ABI still. This allows the `mio` crate tests to now pass on FreeBSD12.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
To be clear, this symbol is available on all FreeBSD versions and not just 12. |
|
@bors: r+ |
|
📌 Commit 969ad2b has been approved by |
bors
added a commit
that referenced
this pull request
Mar 1, 2018
Link against kevent@FBSD_1.0 to fix ABI compat with FreeBSD12. struct kevent was modified in FreeBSD12. The @FBSD_1.0 symbol supports the old structure ABI still. This allows the `mio` crate tests to now pass on FreeBSD12.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct kevent was modified in FreeBSD12. The @FBSD_1.0 symbol supports the old
structure ABI still.
This allows the
miocrate tests to now pass on FreeBSD12.