Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android ci #825

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Fix android ci #825

merged 2 commits into from
Oct 28, 2017

Conversation

malbarbo
Copy link
Contributor

No description provided.

@malbarbo
Copy link
Contributor Author

Tested locally (arm), let's see for the others archs.

@alexcrichton
Copy link
Member

@bors: r+ p=1

Awesome, thanks so much!

@bors
Copy link
Contributor

bors commented Oct 27, 2017

📌 Commit a9115d5 has been approved by alexcrichton

bors added a commit that referenced this pull request Oct 27, 2017
@bors
Copy link
Contributor

bors commented Oct 27, 2017

⌛ Testing commit a9115d5 with merge 20758e5...

@bors
Copy link
Contributor

bors commented Oct 27, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Oct 27, 2017

⌛ Testing commit a9115d5 with merge debbb73...

@bors
Copy link
Contributor

bors commented Oct 27, 2017

💔 Test failed - status-travis

@malbarbo
Copy link
Contributor Author

malbarbo commented Oct 27, 2017

I think the emulator for i686 does not run anymore without hardware acceleration...

qemu-system-i386: -device virtio-blk-pci,drive=system,iothread=disk-iothread,modern-pio-notify: ioeventfd is required for iothread
emulator: WARNING: encryption is off
emulator: WARNING: x86 emulation may not work without hardware acceleration!

I tried to run i686 tests like the x86_64 tests (without the emulator), but I get an error:

assertion failed: signal(libc::SIGPIPE, libc::SIG_IGN) != libc::SIG_ERR

The same I got when adding android testing support to cross. A partial solution was run the tests with qemu-i386, but it needs a patched qemu.

What we do now?

@alexcrichton
Copy link
Member

Hmm that's unfortunate :(

Is hardware acceleration something that needs lots of privs in the cloud? (Aka we will never be able to do this bare on Travis)

If so maybe we should just remove the tests for now?

@alexcrichton
Copy link
Member

@bors: r+

Ok I've pushed a commit to disable it for now, but we can of course reenable if we can get it working again!

@bors
Copy link
Contributor

bors commented Oct 28, 2017

📌 Commit 8617317 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 28, 2017

⌛ Testing commit 8617317 with merge 70df7dc...

bors added a commit that referenced this pull request Oct 28, 2017
@bors
Copy link
Contributor

bors commented Oct 28, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

bors added a commit that referenced this pull request Oct 28, 2017
@bors
Copy link
Contributor

bors commented Oct 28, 2017

⌛ Testing commit 8617317 with merge 93a11fd...

@bors
Copy link
Contributor

bors commented Oct 28, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 93a11fd to master...

@bors bors merged commit 8617317 into rust-lang:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants