Make readdir available on all unix targets #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The readdir_r call has problems, and we'll probably want to move to readdir on many, if not most, unix targets. This patch makes readdir available in unix, rather than just solaris as before. See rust-lang/rust#40021
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Looks like there may be some CI failures? |
Apparently a lot of libc's don't put "const" on the return type for readdir, which causes type mismatch.
|
Yeah, let's see if this fixes it. It's possible some will need const (apparently that worked ok with Solaris) and some mut. |
|
@bors: r+ |
|
📌 Commit 02990f2 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 22, 2017
Make readdir available on all unix targets The readdir_r call has problems, and we'll probably want to move to readdir on many, if not most, unix targets. This patch makes readdir available in unix, rather than just solaris as before. See rust-lang/rust#40021
|
☀️ Test successful - status-appveyor, status-travis |
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
`cargo test --no-run` raise: ``` error[E0432]: unresolved import --> crates/coresimd/src/../../../coresimd/x86/rdtsc.rs:62:9 | 62 | use coresimd::x86::rdtsc; | ^^^^^^^^^^^^^^^^^^^^ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readdir_r call has problems, and we'll probably want to move to
readdir on many, if not most, unix targets. This patch makes readdir
available in unix, rather than just solaris as before.
See rust-lang/rust#40021