emscripten: Assume version is at least 3.1.42 #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Jan 27, 2025
ci/emscripten.sh
Outdated
Comment on lines
5
to
6
| # Note: keep in sync with: | ||
| # https://github.com/rust-lang/rust/blob/master/src/ci/docker/scripts/emscripten.sh |
There was a problem hiding this comment.
Is there something else we should be referencing for version to test with? Maybe the platform docs.
There was a problem hiding this comment.
I've updated this link to https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-unknown-emscripten.md#requirements instead.
|
The changes look fine to me, I think we might even be fine emitting a deprecation warning for old versions in @hoodmane could you take a look at this as well? |
tgross35
added
the
stable-nominated
kleisauke
force-pushed
the
rust-issue-131467
branch
from
880ad61 to
285f0ea
Compare
tgross35
approved these changes
Jan 27, 2025
This revises commit 63b0d67 to assume that Emscripten 3.1.42 or later is being used whenever `emcc` is not available. Since Emscripten 3.1.42 was released on June 23, 2023, the majority of users are expected to have upgraded to a more recent version. Resolves: rust-lang/rust#131467.
tgross35
force-pushed
the
rust-issue-131467
branch
from
285f0ea to
99515f2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revises commit 63b0d67 to assume that Emscripten 3.1.42 or later is being used whenever
emccis not available. Since Emscripten 3.1.42 was released on June 23, 2023, the majority of users are expected to have upgraded to a more recent version.Resolves: rust-lang/rust#131467.