-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2] Require rust >= 1.25 and drop libc_align conditional #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
force-pushed
the
remove-cfg-align
branch
5 times, most recently
from
November 16, 2024 11:29
5e313e8
to
72d962b
Compare
☔ The latest upstream changes (presumably #4053) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
remove-cfg-align
branch
6 times, most recently
from
November 16, 2024 12:21
34af772
to
0663f8d
Compare
tgross35
force-pushed
the
remove-cfg-align
branch
from
November 16, 2024 12:30
0663f8d
to
9d4cd15
Compare
tgross35
force-pushed
the
remove-cfg-align
branch
from
November 16, 2024 12:54
9d4cd15
to
98063fe
Compare
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org>
tgross35
force-pushed
the
remove-cfg-align
branch
from
November 16, 2024 12:56
98063fe
to
b5b553d
Compare
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 17, 2024
This is mostly taken from Josh's work at [1], I just updated to account for conflicts and new uses of `libc_align`. [1]: rust-lang#2845 Co-authored-by: Josh Triplett <josh@joshtriplett.org> (apply <rust-lang#4057> to `main`) (cherry picked from commit b5b553d) As part of this update, drop the `align` feature from Cargo.toml and libc-test. Changes are reduced in this cherry pick compared to the original commit because some of this was already applied to `main`.
tgross35
added
the
main-applied
This PR was merged against libc-0.2 and main has since been updated to include it
label
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly taken from Josh's work at 1, I just updated to account for conflicts and new uses of
libc_align
.