Fix CI for FreeBSD 15 #3950
Merged
Fix CI for FreeBSD 15 #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing for two reasons: * 87fbd9fc7[^1] removed the TCP_MAXPEAKRATE symbol. * 3458bbd39[^2] changed the value of RLIM_NLIMITS Fixes rust-lang#3947 [^1]: freebsd/freebsd-src@87fbd9f [^2]: freebsd/freebsd-src@3458bbd
|
Thanks for the fix, feel free to put up a separate PR doing the other updates suggested at #3947. |
|
Actually, no other changes were necessary. The other symbols that were removed from FreeBSD by that commit were never part of rust's libc. |
asomers
added a commit
to asomers/libc
that referenced
this pull request
Sep 29, 2024
It was failing for two reasons: * 87fbd9fc71[^1] removed the TCP_MAXPEAKRATE symbol. * 3458bbd392[^2] changed the value of RLIM_NLIMITS This is effectively a merge of rust-lang#3950 (commit 590d78d) from the main branch. Fixes rust-lang#3947 [^1]: freebsd/freebsd-src@87fbd9f [^2]: freebsd/freebsd-src@3458bbd
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
It was failing for two reasons: * 87fbd9fc71[^1] removed the TCP_MAXPEAKRATE symbol. * 3458bbd392[^2] changed the value of RLIM_NLIMITS This is effectively a merge of #3950 (commit 590d78d) from the main branch. Fixes #3947 [^1]: freebsd/freebsd-src@87fbd9f [^2]: freebsd/freebsd-src@3458bbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was failing for two reasons:
Fixes #3947
Footnotes
https://github.com/freebsd/freebsd-src/commit/87fbd9fc7fc5f8d79fe5e3dcd13ad02b11a67ef0 ↩
https://github.com/freebsd/freebsd-src/commit/3458bbd397783f3bb62713c54ae87f19eeb98dc0 ↩