Fix tests on FreeBSD x86 #3948
Merged
Fix tests on FreeBSD x86 #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
|
☔ The latest upstream changes (presumably 4ce03da) made this pull request unmergeable. Please resolve the merge conflicts. |
asomers
force-pushed
the
main-i386-fbsd12
branch
from
4873220
to
b38ee9e
Compare
|
@tgross35 this is a follow up to the other PRs you've reviewed for me lately. |
tgross35
added
the
stable-nominated
|
This looks fine at first glance. Could you add links to the relevant headers in the PR description? At least for the few variables that have different values per-arch. |
The definition added in b811b70 was technically wrong even though the type size was correct. It was probably defined this way because earlier versions of Rust had difficulty with fixed-size arrays of size greater than 32. This change is necessary for CI to pass on x86 FreeBSD. https://github.com/freebsd/freebsd-src/blob/main/sys/x86/include/ucontext.h
It's always had the wrong size, but apparently never been tested on 32-bit FreeBSD. In addition to fixing its size, it ought to be moved info freebsd/mod.rs . Otherwise it's pretty much inaccessible to everyone. https://github.com/freebsd/freebsd-src/blob/main/sys/sys/_domainset.h
https://github.com/freebsd/freebsd-src/blob/main/sys/arm/include/_types.h https://github.com/freebsd/freebsd-src/blob/main/sys/arm64/include/_types.h https://github.com/freebsd/freebsd-src/blob/main/sys/powerpc/include/_types.h https://github.com/freebsd/freebsd-src/blob/main/sys/riscv/include/_types.h https://github.com/freebsd/freebsd-src/blob/main/sys/x86/include/_types.h
asomers
force-pushed
the
main-i386-fbsd12
branch
from
d08c4a4
to
0b6cab8
Compare
|
@tgross35 I added links to the header files in all of the commit messages and force-pushed. |
tgross35
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tests on FreeBSD 15 x86. Many of the symbols were wrong for all 32-bit architectures. All of these symbols are fairly obscure, so no real users are known to have encountered problems with them. The discrepancies were never caught because we do CI only on FreeBSD x86_64.
Note: this PR must be rebased after #3946 merges. That PR is much more important since it involves "struct stat", whereas this PR only concerns more obscure symbols.