Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RISC-V vxworks target specific constants #3935

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add RISC-V vxworks target specific constants #3935

merged 1 commit into from
Oct 14, 2024
+20 −2

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Sep 19, 2024 •
edited
Loading

VxWorks RISC-V target specific constants. New RISC-V vxworks target added in rust: rust-lang/rust#130549
This has to be released in stable for std support of these targets.
The reported bug rust-lang/rust#128582 can be closed if #3727 gets cherry picked.
Thank you.

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@biabbas
Copy link
Contributor Author

biabbas commented Sep 19, 2024

r? @tgross35

@rustbot rustbot assigned tgross35 and unassigned JohnTitor Sep 19, 2024
@biabbas biabbas marked this pull request as ready for review September 19, 2024 09:24
@biabbas biabbas marked this pull request as draft September 20, 2024 05:53
@biabbas biabbas force-pushed the riscv_vxworks branch 3 times, most recently from 0d2bbac to f8e3290 Compare September 20, 2024 10:02
@biabbas biabbas changed the title Add riscv vxworks target specific constants Add RISC-V vxworks target specific constants Sep 20, 2024
@biabbas biabbas force-pushed the riscv_vxworks branch 2 times, most recently from cd498a2 to f8e3290 Compare September 20, 2024 12:54
@biabbas biabbas marked this pull request as ready for review September 26, 2024 04:37
@biabbas biabbas force-pushed the riscv_vxworks branch 5 times, most recently from b30cbe6 to 315a9df Compare September 30, 2024 03:59
@biabbas biabbas force-pushed the riscv_vxworks branch 8 times, most recently from 8f96e60 to 79a97c4 Compare October 10, 2024 09:07
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 14, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into rust-lang:main with commit fbec928 Oct 14, 2024
40 of 41 checks passed
@biabbas biabbas deleted the riscv_vxworks branch October 14, 2024 10:56
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 16, 2024
@biabbas @tgross35
Make vxworks functions public and add Risc-V targets
3c09095 
(backport <rust-lang#3935>)
(cherry picked from commit dd20281)
@tgross35 tgross35 mentioned this pull request Oct 16, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biabbas @rustbot @tgross35 @JohnTitor