Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RUSTC_WRAPPER support to build script #3842

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add RUSTC_WRAPPER support to build script #3842

merged 1 commit into from
Aug 16, 2024

Conversation

nathaniel-bennett
Copy link
Contributor

Resolves #3772

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nathaniel-bennett nathaniel-bennett force-pushed the rustc-wrapper-fix branch 4 times, most recently from c7c4c02 to 87e90d6 Compare August 16, 2024 20:48
tgross35
tgross35 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 16, 2024
@tgross35 tgross35 added this pull request to the merge queue Aug 16, 2024
Merged via the queue into rust-lang:main with commit fc28283 Aug 16, 2024
39 checks passed
@tgross35 tgross35 mentioned this pull request Aug 17, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 17, 2024
@tgross35 tgross35 mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build script does not respect RUSTC_WRAPPER
3 participants
@nathaniel-bennett @rustbot @tgross35