-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the ioctl declarations on linux #3722
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
106748e
to
9b4aea4
Compare
☔ The latest upstream changes (presumably #3777) made this pull request unmergeable. Please resolve the merge conflicts. |
9b4aea4
to
01a3617
Compare
This uses the existing Ioctl type to reduce the duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice cleanup, thanks. Could you double check that the tests in libc-test/semver
are up to date?
I can't run the tests, since ctest2 complains that
|
In fact, ioctl is listed in unix.txt, so it is already expected everywhere. |
Thanks for confirming! |
This uses the existing Ioctl type to reduce the duplication. (backport <rust-lang#3722>) (cherry picked from commit 01a3617)
I originally wanted to have all versions take a c_uint, since that is what the kernel expects on the other side. I then found that the test infrastructure, quite reasonably, enforces that the symbol matches what the C library provides.
So this PR is now just a small cleanup that uses the existing Ioctl type to reduce duplication.