Move testing of primitive types from std #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use r? to explicitly pick a reviewer |
|
Oh wait I just noticed an issue. This needs to be added to the libc-test Cargo.toml otherwise it's not actually being run. |
|
Wow that is deceptive. We should just use |
|
Yeah, that sounds like a good idea. I only noticed because I looked at it in my editor and it helpfully greyed out the code. I couldn't immediately figure out why so I investigated further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std shouldn't need to depend on libc for platforms that don't require it, but currently one test means it is required.
It was suggested that this test more properly belongs in the libc crate itself, so I've made this PR for your consideration.