Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ucontext for linux-musl. #255

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Add ucontext for linux-musl. #255

merged 1 commit into from
Apr 15, 2016

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Apr 7, 2016

It just copy pasted from the linux-other version.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@fiveop
Copy link
Contributor Author

fiveop commented Apr 7, 2016

Given that musl certainly exports these methods

$ git grep getcontext # in a clone of musl's master branch
include/ucontext.h:int  getcontext(struct __ucontext *);

and ucontext.h is imported on linux indiscriminately (see lib-test\build.rs), why does the build fail because of undefined references to this (and similar) functions ( https://travis-ci.org/rust-lang/libc/jobs/121508994 )?

@alexcrichton
Copy link
Member

I believe that while declared in MUSL the functions aren't actually defined.

@fiveop
Copy link
Contributor Author

fiveop commented Apr 15, 2016

You are right: http://wiki.musl-libc.org/wiki/Open_Issues#ucontext.h . But It does provide the struct, so I removed just the functions declarations.

@@ -1,3 +1,18 @@
pub const SYS_gettid: ::c_long = 186;

pub const SYS_perf_event_open: ::c_long = 298;

s! {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently structs come before constants, but otherwise this looks good to me!

@fiveop
Copy link
Contributor Author

fiveop commented Apr 15, 2016

done

@alexcrichton
Copy link
Member

@bors: r+ d780eec

@bors
Copy link
Contributor

bors commented Apr 15, 2016

⌛ Testing commit d780eec with merge 779cde8...

bors added a commit that referenced this pull request Apr 15, 2016
Add ucontext for linux-musl.

It just copy pasted from the linux-other version.
@bors
Copy link
Contributor

bors commented Apr 15, 2016

☀️ Test successful - status-appveyor, travis

@bors bors merged commit d780eec into rust-lang:master Apr 15, 2016
@fiveop fiveop deleted the ucontext_musl branch May 1, 2016 14:02
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
…st-lang#255)

* sse: _mm_cvtpi16_ps, _mm_cvtpu16_ps, _mm_cvtpi8_ps, _mm_cvtpu8_ps

And mmx:
_mm_cmpgt_pi8
_mm_cmpgt_pi16
_mm_unpackhi_pi16
_mm_unpacklo_pi8
_mm_unpacklo_pi16

* Fix: literal out of range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants