Implement RFC 1291 changes #21
Conversation
[ci skip]
Add FIONBIO
Conflicts: rust
| __variant1, | ||
| #[doc(hidden)] | ||
| __variant2, | ||
| } |
There was a problem hiding this comment.
Can these be private? This seems risky exposing these bogus fields.
There was a problem hiding this comment.
Also, why does this want to be u8? Can you comment?
There was a problem hiding this comment.
Unfortunately I don't think they can be private (no way to have a public enum with private variants), but I think we're covered in terms of "reasonable backwards compatibility". I've added a comment though.
|
I don't see a version bump in Cargo.toml. What's the version after this lands? |
| pub fn memchr(cx: *const c_void, c: c_int, n: size_t) -> *mut c_void; | ||
| } | ||
|
|
||
| // These are all inline functions on android |
There was a problem hiding this comment.
What does that mean for their definition in Rust? Do we provide compatibility? Can you comment?
There was a problem hiding this comment.
Right now this just means they're not defined in Rust at all, so they just don't show up in the docs at all, but I'll add a comment.
|
Stunning work. |
|
I plan to run some more tests and migrate a few repos to this, and then after that I'll bump to 1.0.0 and release |
|
OK. I'm pretty concerned about the ramifications of bumping this massively complicated crate to 1.0. Before you do it you should reassure me that we can maintain semver. Here's hoping the test coverage is amazing, since I just have to take your word all these definitions are correct. r=me |
|
Gonna go ahead and merge now, as discussed on IRC we can hold off on the version bump/publish for now. |
Implement RFC 1291 changes
Use / as prefix instead of /usr for binutils/gcc
# This is the 1st commit message: chore: add labels to FIXMEs # This is the commit message rust-lang#2: change label for .field FIXMEs # This is the commit message rust-lang#3: add fixme csv # This is the commit message rust-lang#4: Update fixmes.csv # This is the commit message rust-lang#5: Update fixmes.csv # This is the commit message rust-lang#6: Update fixmes.csv # This is the commit message rust-lang#7: Update fixmes.csv # This is the commit message rust-lang#8: Update fixmes.csv # This is the commit message rust-lang#9: Update fixmes.csv # This is the commit message rust-lang#10: Update fixmes.csv # This is the commit message rust-lang#11: Update fixmes.csv # This is the commit message rust-lang#12: Update fixmes.csv # This is the commit message rust-lang#13: Update fixmes.csv # This is the commit message rust-lang#14: Update fixmes.csv # This is the commit message rust-lang#15: Update fixmes.csv # This is the commit message rust-lang#16: Update fixmes.csv # This is the commit message rust-lang#17: Update fixmes.csv # This is the commit message rust-lang#18: updates to csv # This is the commit message rust-lang#19: Update fixmes.csv # This is the commit message rust-lang#20: Update fixmes.csv # This is the commit message rust-lang#21: Update fixmes.csv # This is the commit message rust-lang#22: Update fixmes.csv remove hurd" # This is the commit message rust-lang#23: Update fixmes.csv remove "'s
This PR is an implementation of RFC 1291 which contains the changes before migrating this repo to the rust-lang organization.