-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add base definitions for riscv64 + musl #1994
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Is there any riscv target that uses musl as |
There will be soon. I am working on porting Alpine Linux to RISC-V. You can follow along with that work here: |
Then I'd love to see a target spec as JSON and run CI for it, to make sure the build. And you should consider sending a PR to add a new target to rust-lang/rust, I think. |
Yeah, I will have something for rust-lang/rust as well. I need to finish bootstrapping the damn thing first, what a miserable process. Can you elaborate on the target spec as JSON issue? |
We can pass a target spec as JSON, like https://github.com/rust-lang/libc/blob/master/ci/switch.json, to run the build test. |
It might be helpful to see how aarch64 did it: rust-lang/rust#74541 |
|
☔ The latest upstream changes (presumably #2071) made this pull request unmergeable. Please resolve the merge conflicts. |
Great! I'm not sure how difficult to run ctest on that target but at least we should run the build check on CI, as I said before. It can be done easily by tweaking here: https://github.com/rust-lang/libc/blob/master/ci/build.sh |
I'm going to close as inactive, feel free to rebase and re-open when you get some time :) |
Add base definitions for riscv64 + musl This is picking up the stale MR that was closed for inactivity: #1994
Add base definitions for riscv64 + musl This is picking up the stale MR that was closed for inactivity: #1994
Add base definitions for riscv64 + musl This is picking up the stale MR that was closed for inactivity: #1994
No description provided.