Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timer_create and related calls #1900

Closed
wants to merge 1 commit into from

Conversation

@rust-highfive
Copy link

r? @JohnTitor

(rust_highfive has picked a reviewer for you, use r? to override)

Added:
* timer_create
* timer_getoverrun
* timer_gettime
* timer_settime
* timer_delete
@joshtriplett
Copy link
Member

Closing and reopening to re-run CI.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is marked as WIP but no activities for about a month so leaving some reviews. I have a question about timer_t but other structs/functions definitions look good to me.

@@ -13,6 +13,7 @@ pub type speed_t = ::c_uint;
pub type nl_item = ::c_int;
pub type id_t = i64;
pub type vm_size_t = ::uintptr_t;
pub type timer_t = *mut ::c_void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -10,6 +10,7 @@ type __pthread_spin_t = __cpu_simple_lock_nv_t;
pub type vm_size_t = ::uintptr_t;
pub type lwpid_t = ::c_uint;
pub type shmatt_t = ::c_uint;
pub type timer_t = *mut ::c_void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, seems it's defined as int, am I missing something?

https://github.com/NetBSD/src/search?q=_BSD_TIMER_T_

@@ -4,6 +4,7 @@ pub type tcflag_t = ::c_uint;
pub type clockid_t = ::c_int;
pub type key_t = ::c_int;
pub type id_t = ::c_uint;
pub type timer_t = *mut ::c_void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Android and Linux define __kernel_timer_t as int?

@bors
Copy link
Contributor

bors commented Oct 27, 2020

☔ The latest upstream changes (presumably #1961) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@Zapeth Zapeth mentioned this pull request Jun 1, 2021
5 tasks
@JohnTitor
Copy link
Member

Triage: I'm going to close this PR as inactive and some items are declared now, if there're still missing items and you find some time to work on it again, feel free to submit a new PR for it, thanks!

@JohnTitor JohnTitor closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants