Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settimeofday for solaris/illumos #1549

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

GrayJack
Copy link
Contributor

Closes #1547

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 14, 2019

@mati865 all musl targets are broken on nightly, is this known ?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 14, 2019

So the PR that broke this has been reverted and the next nightly shouldn't have this issue.

@mati865
Copy link
Contributor

mati865 commented Oct 14, 2019

Yeah all targets packaging start objects are broken.
Revert PR has failed multiple times (very unlucky) rust-lang/rust#65342 so it will be fixed tomorrow.

@GrayJack
Copy link
Contributor Author

Is it fixed now?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019

@GrayJack thanks for the ping, yes, it was fixed a couple of hours ago.

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit fb06358 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 15, 2019

⌛ Testing commit fb06358 with merge 99bef8d...

bors added a commit that referenced this pull request Oct 15, 2019
Add settimeofday for solaris/illumos

Closes #1547
@bors
Copy link
Contributor

bors commented Oct 15, 2019

💔 Test failed - checks-cirrus-freebsd-11

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019

cc @asomers @kinnison - so apparently rustup fails on FreeBSD11 because of some components not being available.

EDIT: @kinnison this looks like a rustup bug, where it tries to install components that are not available for a target. Can it be that the new profiles do not know that certain targets never have some components ? (I'm not sure if FreeBSD11 sometimes has clippy and rustfmt).

@mati865
Copy link
Contributor

mati865 commented Oct 15, 2019

^ opened #1550

bors added a commit that referenced this pull request Oct 15, 2019
Use minimal profile for rustup

Haven't tested it but should fix issue from #1549 (comment)
@kinnison
Copy link

EDIT: @kinnison this looks like a rustup bug, where it tries to install components that are not available for a target. Can it be that the new profiles do not know that certain targets never have some components ? (I'm not sure if FreeBSD11 sometimes has clippy and rustfmt).

I'm aware of something like this on lower tier platforms yes. I've a fix in-train which might go out tomorrow for that part.

@asomers
Copy link
Contributor

asomers commented Oct 15, 2019

cc @asomers @kinnison - so apparently rustup fails on FreeBSD11 because of some components not being available.

EDIT: @kinnison this looks like a rustup bug, where it tries to install components that are not available for a target. Can it be that the new profiles do not know that certain targets never have some components ? (I'm not sure if FreeBSD11 sometimes has clippy and rustfmt).

FreeBSD11 is supposed to have clippy and rustfmt, as should most platforms. But it hasn't since late May due to this bug: rust-lang/rust#62558 .

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 15, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Support vxWorks in libc-test #1543

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit fb06358 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit fb06358 with merge d44c427...

bors added a commit that referenced this pull request Oct 16, 2019
Add settimeofday for solaris/illumos

Closes #1547
@bors
Copy link
Contributor

bors commented Oct 16, 2019

💔 Test failed - status-azure

@GrayJack
Copy link
Contributor Author

Doesn't seem to have something to do with my changes, only linux-android failed

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Oct 17, 2019

⌛ Testing commit fb06358 with merge bf877ba...

bors added a commit that referenced this pull request Oct 17, 2019
Add settimeofday for solaris/illumos

Closes #1547
@bors
Copy link
Contributor

bors commented Oct 17, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing bf877ba to master...

@bors bors merged commit fb06358 into rust-lang:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solaris does not expose settimeofday
7 participants