-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settimeofday for solaris/illumos #1549
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@mati865 all musl targets are broken on nightly, is this known ? |
So the PR that broke this has been reverted and the next nightly shouldn't have this issue. |
Yeah all targets packaging start objects are broken. |
Is it fixed now? |
📌 Commit fb06358 has been approved by |
Add settimeofday for solaris/illumos Closes #1547
💔 Test failed - checks-cirrus-freebsd-11 |
cc @asomers @kinnison - so apparently rustup fails on FreeBSD11 because of some components not being available. EDIT: @kinnison this looks like a rustup bug, where it tries to install components that are not available for a target. Can it be that the new profiles do not know that certain targets never have some components ? (I'm not sure if FreeBSD11 sometimes has clippy and rustfmt). |
^ opened #1550 |
Use minimal profile for rustup Haven't tested it but should fix issue from #1549 (comment)
I'm aware of something like this on lower tier platforms yes. I've a fix in-train which might go out tomorrow for that part. |
FreeBSD11 is supposed to have clippy and rustfmt, as should most platforms. But it hasn't since late May due to this bug: rust-lang/rust#62558 . |
@bors: r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit fb06358 has been approved by |
Add settimeofday for solaris/illumos Closes #1547
💔 Test failed - status-azure |
Doesn't seem to have something to do with my changes, only linux-android failed |
@bors: retry |
Add settimeofday for solaris/illumos Closes #1547
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
Closes #1547