-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powerpc64-unknown-freebsd target #1358
Conversation
Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR, you might want to add here aarch64 as well. FYI, this repo has nothing to do with stdsimd. My comment there was suggesting setting up a similar system as the one set up here, but on that repo, to be able to test these targets there as well. |
You need to add these targets to the |
Move to RUST_NIGHTLY_LINUX_TARGETS per gznlbg's suggestion.
Damn, they need to be in the "LINUX_NO_CORE_TARGETS" apparently: https://github.com/rust-lang/libc/pull/1358/files#diff-78b1794b72c7105dbabbe466019395d6L170 |
Move to LINUX_NO_CORE_TARGETS per gznlbg's suggestion.
Thank you! Now it worked! @bors: r+ |
📌 Commit 49271b7 has been approved by |
Add powerpc64-unknown-freebsd target Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
💔 Test failed - checks-travis |
@bors: retry |
Add powerpc64-unknown-freebsd target Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
💔 Test failed - checks-travis |
@bors: retry |
Add powerpc64-unknown-freebsd target Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
Add powerpc64-unknown-freebsd target Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.